hermes-agent/hermes-agent-features
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity

fix(telegram): exempt reply_to_mode=off DM topic sends from anchor-required guard

Browse Source 
Salvage follow-up. The new private-DM-topic fail-loud contract from
PR #27107 hits 'requires a reply anchor' when reply_to_mode='off' is
configured, even though commit 21a15b671 (PR #23994) verified that
message_thread_id alone routes correctly on python-telegram-bot's
reference client when the user has explicitly opted out of quote
bubbles. Carve out the explicit opt-in path so users on reply_to_mode
'off' aren't regressed — the new guard now only applies to callers
that didn't ask for the anchor to be suppressed.
This commit is contained in:
teknium1 2026-05-25 14:45:28 -07:00 committed by Teknium
parent 926da69b45
commit 27df4b3882
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gateway/platforms/telegram.py
View File

@ -1848,6 +1848,16 @@ class TelegramAdapter(BasePlatformAdapter):
retried_thread_not_found = False retried_thread_not_found = False
metadata_reply_to = self._metadata_reply_to_message_id(metadata) metadata_reply_to = self._metadata_reply_to_message_id(metadata)
private_dm_topic_send = self._is_private_dm_topic_send(chat_id, thread_id, metadata) private_dm_topic_send = self._is_private_dm_topic_send(chat_id, thread_id, metadata)
# reply_to_mode="off" on the existing telegram_dm_topic_reply_fallback path
# is an explicit user opt-in to "message_thread_id alone is enough" (PR #23994
# / commit 21a15b671). Honor it — don't fail loud just because the anchor was
# suppressed by config. The new fail-loud contract only applies when the caller
# didn't ask for the anchor to be dropped.
dm_topic_reply_to_off = (
private_dm_topic_send
and self._reply_to_mode == "off"
and bool(metadata and metadata.get("telegram_dm_topic_reply_fallback"))
)
reply_to_source = reply_to or ( reply_to_source = reply_to or (
str(metadata_reply_to) if private_dm_topic_send and metadata_reply_to is not None else None str(metadata_reply_to) if private_dm_topic_send and metadata_reply_to is not None else None
) )
@ -1859,7 +1869,7 @@ class TelegramAdapter(BasePlatformAdapter):
else: else:
should_thread = self._should_thread_reply(reply_to_source, i) should_thread = self._should_thread_reply(reply_to_source, i)
reply_to_id = int(reply_to_source) if should_thread and reply_to_source else None reply_to_id = int(reply_to_source) if should_thread and reply_to_source else None
if private_dm_topic_send and reply_to_id is None: if private_dm_topic_send and reply_to_id is None and not dm_topic_reply_to_off:
return SendResult( return SendResult(
success=False, success=False,
error=self._dm_topic_missing_anchor_error(), error=self._dm_topic_missing_anchor_error(),