From 32e8f952fd0323891611042531053b945bd40f79 Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Sun, 24 Jun 2018 02:21:27 +0300 Subject: [PATCH] Even more lints! --- hammond-downloader/src/lib.rs | 10 +++++++++- hammond-gtk/src/main.rs | 10 +++++++++- hammond-gtk/src/widgets/player.rs | 2 +- 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/hammond-downloader/src/lib.rs b/hammond-downloader/src/lib.rs index 7ac819a..a1a7ee8 100644 --- a/hammond-downloader/src/lib.rs +++ b/hammond-downloader/src/lib.rs @@ -1,7 +1,15 @@ #![recursion_limit = "1024"] -#![warn(unused_extern_crates, unused)] #![allow(unknown_lints)] #![cfg_attr(feature = "cargo-clippy", allow(blacklisted_name, option_map_unit_fn))] +// Enable lint group collections +#![warn(nonstandard_style, edition_2018, rust_2018_idioms, bad_style, unused)] +// standalone lints +#![warn( + const_err, improper_ctypes, non_shorthand_field_patterns, no_mangle_generic_items, + overflowing_literals, plugin_as_library, private_no_mangle_fns, private_no_mangle_statics, + unconditional_recursion, unions_with_drop_fields, while_true, missing_debug_implementations, + trivial_casts, trivial_numeric_casts, elided_lifetime_in_paths, missing_copy_implementations +)] #![deny(warnings)] extern crate failure; diff --git a/hammond-gtk/src/main.rs b/hammond-gtk/src/main.rs index 9322f42..b317e25 100644 --- a/hammond-gtk/src/main.rs +++ b/hammond-gtk/src/main.rs @@ -3,7 +3,15 @@ allow(clone_on_ref_ptr, blacklisted_name, match_same_arms, option_map_unit_fn) )] #![allow(unknown_lints)] -#![warn(unused_extern_crates, unused)] +// Enable lint group collections +#![warn(nonstandard_style, edition_2018, rust_2018_idioms, bad_style, unused)] +// standalone lints +#![warn( + const_err, improper_ctypes, non_shorthand_field_patterns, no_mangle_generic_items, + overflowing_literals, plugin_as_library, private_no_mangle_fns, private_no_mangle_statics, + unconditional_recursion, unions_with_drop_fields, while_true, missing_debug_implementations, + trivial_casts, trivial_numeric_casts, elided_lifetime_in_paths, missing_copy_implementations +)] #![deny(warnings)] extern crate gdk; diff --git a/hammond-gtk/src/widgets/player.rs b/hammond-gtk/src/widgets/player.rs index 4ec2362..427047b 100644 --- a/hammond-gtk/src/widgets/player.rs +++ b/hammond-gtk/src/widgets/player.rs @@ -355,7 +355,7 @@ impl PlayerWidget { fn connect_update_slider(slider: >k::Scale, player: &gst_player::Player) -> SignalHandlerId { slider.connect_value_changed(clone!(player => move |slider| { let value = slider.get_value() as u64; - player.seek(ClockTime::from_seconds(value as u64)); + player.seek(ClockTime::from_seconds(value)); })) } }