toxblh/podcasts
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hammond-data::parser: Prefer itunes_summary over channel.description if it exists. Finishes #20.

Browse Source
This commit is contained in:
Jordan Petridis 2017-12-27 17:59:40 +02:00
parent 1f0a2b5c6c
commit 7d7b09ff0f
No known key found for this signature in database
GPG Key ID: CEABAD9F5683B9A6
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
hammond-data/src/parser.rs
View File

@ -12,7 +12,14 @@ use errors::*;
/// Parses a `rss::Channel` into a `NewPodcast` Struct. /// Parses a `rss::Channel` into a `NewPodcast` Struct.
pub(crate) fn new_podcast(chan: &Channel, source_id: i32) -> NewPodcast { pub(crate) fn new_podcast(chan: &Channel, source_id: i32) -> NewPodcast {
let title = chan.title().trim(); let title = chan.title().trim();
let description = replace_extra_spaces(&ammonia::clean(chan.description()));
// Prefer itunes summary over rss.description since many feeds put html into rss.description.
let summary = chan.itunes_ext().map(|s| s.summary()).and_then(|s| s);
let description = if let Some(sum) = summary {
replace_extra_spaces(&ammonia::clean(sum))
} else {
replace_extra_spaces(&ammonia::clean(chan.description()))
};
let link = url_cleaner(chan.link()); let link = url_cleaner(chan.link());
let x = chan.itunes_ext().map(|s| s.image()); let x = chan.itunes_ext().map(|s| s.image());
@ -42,6 +49,7 @@ pub(crate) fn new_episode(item: &Item, parent_id: i32) -> Result<NewEpisode> {
let title = item.title().unwrap().trim().to_owned(); let title = item.title().unwrap().trim().to_owned();
let guid = item.guid().map(|s| s.value().trim().to_owned()); let guid = item.guid().map(|s| s.value().trim().to_owned());
// Prefer itunes summary over rss.description since many feeds put html into rss.description.
let summary = item.itunes_ext().map(|s| s.summary()).and_then(|s| s); let summary = item.itunes_ext().map(|s| s.summary()).and_then(|s| s);
let description = if summary.is_some() { let description = if summary.is_some() {
summary.map(|s| replace_extra_spaces(&ammonia::clean(s))) summary.map(|s| replace_extra_spaces(&ammonia::clean(s)))
@ -155,9 +163,8 @@ mod tests {
let file = File::open("tests/feeds/TheBreakthrough.xml").unwrap(); let file = File::open("tests/feeds/TheBreakthrough.xml").unwrap();
let channel = Channel::read_from(BufReader::new(file)).unwrap(); let channel = Channel::read_from(BufReader::new(file)).unwrap();
let descr = "Latest Articles and Investigations from ProPublica, an independent, \ let descr = "The podcast that takes you behind the scenes with journalists to hear how \
non-profit newsroom that produces investigative journalism in the public \ they nailed their biggest stories.";
interest.";
let pd = new_podcast(&channel, 0); let pd = new_podcast(&channel, 0);
let expected = NewPodcastBuilder::default() let expected = NewPodcastBuilder::default()