toxblh/podcasts
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Utils: do not block the cover_dl registry

Browse Source 
Accidently after f21398357b when a download would start,
it would lock the cover_dl_registry hashmap till it had finished.

Since the registry.read() happens on the main thread this would
cause the UI to block until the download was and the mutex guard
from the download thread dropped.
This commit is contained in:
Jordan Petridis 2018-08-28 20:43:45 +03:00 committed by Jordan Petridis
parent 132e2afce0
commit 822deb2867
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
podcasts-gtk/src/utils.rs
View File

@ -288,9 +288,14 @@ pub(crate) fn set_image_from_path(
THREADPOOL.spawn(move || {
if let Ok(mut guard) = COVER_DL_REGISTRY.write() {
guard.insert(show_id);
if let Ok(pd) = dbqueries::get_podcast_cover_from_id(show_id) {
sender.send(downloader::cache_image(&pd));
}
}
// This operation is polling and will block the thread till the download is finished
if let Ok(pd) = dbqueries::get_podcast_cover_from_id(show_id) {
sender.send(downloader::cache_image(&pd));
}
if let Ok(mut guard) = COVER_DL_REGISTRY.write() {
guard.remove(&show_id);
}
});