From 89564996df84bb3edcb7b1670a7e34484652d86d Mon Sep 17 00:00:00 2001
From: Jordan Petridis <jordanpetridis@protonmail.com>
Date: Wed, 7 Feb 2018 01:19:07 +0200
Subject: [PATCH] ShowStack: Convert rest methods to return Result<T, Error>.

---
 hammond-gtk/src/app.rs     |  7 ++++++-
 hammond-gtk/src/content.rs | 37 +++++++++++++++++--------------------
 2 files changed, 23 insertions(+), 21 deletions(-)

diff --git a/hammond-gtk/src/app.rs b/hammond-gtk/src/app.rs
index fc48072..5a13913 100644
--- a/hammond-gtk/src/app.rs
+++ b/hammond-gtk/src/app.rs
@@ -134,7 +134,12 @@ impl App {
                 Ok(Action::RefreshWidgetIfSame(id)) => content.update_widget_if_same(id),
                 Ok(Action::RefreshEpisodesView) => content.update_episode_view(),
                 Ok(Action::RefreshEpisodesViewBGR) => content.update_episode_view_if_baground(),
-                Ok(Action::ReplaceWidget(ref pd)) => content.get_shows().replace_widget(pd),
+                Ok(Action::ReplaceWidget(ref pd)) => {
+                    if let Err(err) = content.get_shows().replace_widget(pd) {
+                        error!("Something went wrong while trying to update the ShowWidget.");
+                        error!("Error: {}", err);
+                    }
+                }
                 Ok(Action::ShowWidgetAnimated) => content.get_shows().switch_widget_animated(),
                 Ok(Action::ShowShowsAnimated) => content.get_shows().switch_podcasts_animated(),
                 Ok(Action::HeaderBarShowTile(title)) => headerbar.switch_to_back(&title),
diff --git a/hammond-gtk/src/content.rs b/hammond-gtk/src/content.rs
index 9b923d5..17811cd 100644
--- a/hammond-gtk/src/content.rs
+++ b/hammond-gtk/src/content.rs
@@ -63,7 +63,10 @@ impl Content {
     }
 
     pub fn update_shows_view(&self) {
-        self.shows.update_podcasts();
+        if let Err(err) = self.shows.update_podcasts() {
+            error!("Something went wrong while trying to update the ShowsView.");
+            error!("Error: {}", err);
+        }
     }
 
     pub fn update_widget(&self) {
@@ -134,26 +137,22 @@ impl ShowStack {
     //     self.update_podcasts();
     // }
 
-    pub fn update_podcasts(&self) {
+    pub fn update_podcasts(&self) -> Result<(), Error> {
         let vis = self.stack.get_visible_child_name().unwrap();
 
         let old = self.stack
             .get_child_by_name("podcasts")
-            // This is guaranted to exists, based on `ShowStack::new()`.
-            .unwrap()
+            .ok_or_else(|| format_err!("Faild to get \"podcasts\" child from the stack."))?
             .downcast::<gtk::Box>()
-            // This is guaranted to be a Box based on the `ShowsPopulated` impl.
-            .unwrap();
+            .map_err(|_| format_err!("Failed to downcast stack child to a Box."))?;
         debug!("Name: {:?}", WidgetExt::get_name(&old));
 
         let scrolled_window = old.get_children()
             .first()
-            // This is guaranted to exist based on the show_widget.ui file.
-            .unwrap()
+            .ok_or_else(|| format_err!("Box container has no childs."))?
             .clone()
             .downcast::<gtk::ScrolledWindow>()
-            // This is guaranted based on the show_widget.ui file.
-            .unwrap();
+            .map_err(|_| format_err!("Failed to downcast stack child to a ScrolledWindow."))?;
         debug!("Name: {:?}", WidgetExt::get_name(&scrolled_window));
 
         let pop = ShowsPopulated::new(self.sender.clone());
@@ -174,16 +173,15 @@ impl ShowStack {
         }
 
         old.destroy();
+        Ok(())
     }
 
-    pub fn replace_widget(&self, pd: &Podcast) {
+    pub fn replace_widget(&self, pd: &Podcast) -> Result<(), Error> {
         let old = self.stack
             .get_child_by_name("widget")
-            // This is guaranted to exists, based on `ShowStack::new()`.
-            .unwrap()
+            .ok_or_else(|| format_err!("Faild to get \"widget\" child from the stack."))?
             .downcast::<gtk::Box>()
-            // This is guaranted to be a Box based on the `ShowWidget` impl.
-            .unwrap();
+            .map_err(|_| format_err!("Failed to downcast stack child to a Box."))?;
         debug!("Name: {:?}", WidgetExt::get_name(&old));
 
         let new = ShowWidget::new(pd, self.sender.clone());
@@ -197,12 +195,10 @@ impl ShowStack {
         if newid == oldid {
             let scrolled_window = old.get_children()
                 .first()
-                // This is guaranted to exist based on the show_widget.ui file.
-                .unwrap()
+                .ok_or_else(|| format_err!("Box container has no childs."))?
                 .clone()
                 .downcast::<gtk::ScrolledWindow>()
-                // This is guaranted based on the show_widget.ui file.
-                .unwrap();
+                .map_err(|_| format_err!("Failed to downcast stack child to a ScrolledWindow."))?;
             debug!("Name: {:?}", WidgetExt::get_name(&scrolled_window));
 
             // Copy the vertical scrollbar adjustment from the old view into the new one.
@@ -213,6 +209,7 @@ impl ShowStack {
 
         self.stack.remove(&old);
         self.stack.add_named(&new.container, "widget");
+        Ok(())
     }
 
     pub fn update_widget(&self) -> Result<(), Error> {
@@ -230,7 +227,7 @@ impl ShowStack {
 
         let id = id.ok_or_else(|| format_err!("Failed to get widget's name."))?;
         let pd = dbqueries::get_podcast_from_id(id.parse::<i32>()?)?;
-        self.replace_widget(&pd);
+        self.replace_widget(&pd)?;
         self.stack.set_visible_child_name(&vis);
         old.destroy();
         Ok(())