From 86f6a944ffd75d53c435836874430fd677e8f4bb Mon Sep 17 00:00:00 2001
From: FeuRenard <feurenard@posteo.de>
Date: Sun, 12 May 2019 17:55:20 +0200
Subject: [PATCH] headerbar: Don't show error when add input is empty

When you add a feed url and clear the input after entering some
characters, then the error label is shown. The empty url check in the
code is broken, because it is performed on a version of the url which
is not the original input and instead a version modified in the code.

I store in a variable whether the original input url is empty.

part of #45
---
 podcasts-gtk/src/headerbar.rs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/podcasts-gtk/src/headerbar.rs b/podcasts-gtk/src/headerbar.rs
index 880e822..9feba7e 100644
--- a/podcasts-gtk/src/headerbar.rs
+++ b/podcasts-gtk/src/headerbar.rs
@@ -96,6 +96,7 @@ impl AddPopover {
             .entry
             .get_text()
             .ok_or_else(|| format_err!("GtkEntry blew up somehow."))?;
+        let is_input_url_empty = url.is_empty();
         debug!("Url: {}", url);
 
         if !(url.starts_with("https://") || url.starts_with("http://")) {
@@ -131,7 +132,7 @@ impl AddPopover {
             }
             Err(err) => {
                 self.add.set_sensitive(false);
-                if !url.is_empty() {
+                if !is_input_url_empty {
                     self.entry
                         .get_style_context()
                         .add_class(&gtk::STYLE_CLASS_ERROR);