Remove TODOs and FIXMEs

They are either no longer relevant or just forgotten
This commit is contained in:
Jordan Petridis 2018-08-14 11:18:23 +03:00
parent 646439d86a
commit c53ad56a6d
No known key found for this signature in database
GPG Key ID: CEABAD9F5683B9A6
4 changed files with 0 additions and 7 deletions

View File

@ -47,7 +47,6 @@ pub enum DataError {
#[fail(display = "Hyper Error: {}", _0)]
HyperError(#[cause] hyper::Error),
#[fail(display = "Failed to parse a url: {}", _0)]
// TODO: print the url too
UrlError(#[cause] url::ParseError),
#[fail(display = "TLS Error: {}", _0)]
TLSError(#[cause] native_tls::Error),

View File

@ -18,7 +18,6 @@ use std::rc::Rc;
use i18n::i18n;
#[derive(Debug, Clone)]
// TODO: Factor out the hamburger menu
// TODO: Make a proper state machine for the headerbar states
pub(crate) struct Header {
pub(crate) container: gtk::HeaderBar,

View File

@ -72,7 +72,6 @@ pub(crate) fn lazy_load<T, C, F, W, U>(
) where
T: IntoIterator + 'static,
T::Item: 'static,
// FIXME: leaking a strong refference here
C: IsA<Object> + ContainerExt + 'static,
F: FnMut(T::Item) -> W + 'static,
W: IsA<Widget> + WidgetExt,
@ -337,8 +336,6 @@ pub(crate) fn on_import_clicked(window: &gtk::ApplicationWindow, sender: &Sender
use glib::translate::ToGlib;
use gtk::{FileChooserAction, FileChooserNative, FileFilter, ResponseType};
// let dialog = FileChooserDialog::new(title, Some(&window), FileChooserAction::Open);
// TODO: It might be better to use a FileChooserNative widget.
// Create the FileChooser Dialog
let dialog = FileChooserNative::new(
Some(i18n("Select the file from which to you want to import shows.").as_str()),
@ -361,7 +358,6 @@ pub(crate) fn on_import_clicked(window: &gtk::ApplicationWindow, sender: &Sender
dialog.connect_response(clone!(sender => move |dialog, resp| {
debug!("Dialog Response {}", resp);
if resp == ResponseType::Accept.to_glib() {
// TODO: Show an in-app notification if the file can not be accessed
if let Some(filename) = dialog.get_filename() {
debug!("File selected: {:?}", filename);

View File

@ -159,7 +159,6 @@ fn split(now: &DateTime<Utc>, epoch: i64) -> ListSplit {
struct HomeEpisode {
container: gtk::Box,
image: gtk::Image,
// FIXME: Change it to `EpisodeWidget` instead of a `Box`?
episode: gtk::Box,
}