Visual tweaks, and other minor stuff.

Added margins bottom margins on EpisodesView and ShowWidget.
Added some comment's to the code.
Silenced needless_pass_by_value clippy warning.
Updated TODO.md.
This commit is contained in:
Jordan Petridis
2017-12-23 16:56:03 +02:00
parent 30970c8dfb
commit e7185d2cd3
6 changed files with 20 additions and 18 deletions
+1 -1
View File
@@ -1,4 +1,4 @@
#![cfg_attr(feature = "cargo-clippy", allow(clone_on_ref_ptr))]
#![cfg_attr(feature = "cargo-clippy", allow(clone_on_ref_ptr, needless_pass_by_value))]
extern crate gdk;
extern crate gdk_pixbuf;
+7 -1
View File
@@ -68,7 +68,13 @@ lazy_static! {
};
}
// FIXME: use something that would just scale?
// Since gdk_pixbuf::Pixbuf is refference counted and every episode,
// use the cover of the Podcast Feed/Show, We can only create a Pixbuf
// cover per show and pass around the Rc pointer.
//
// GObjects do not implement Send trait, so SendCell is a way around that.
// Also lazy_static requires Sync trait, so that's what the mutexes are.
// TODO: maybe use something that would just scale to requested size?
pub fn get_pixbuf_from_path(pd: &PodcastCoverQuery, size: u32) -> Option<Pixbuf> {
let mut hashmap = CACHED_PIXBUFS.lock().unwrap();
{