toxblh/podcasts
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
1,389 Commits 6 Branches 16 Tags
9f42e910880a9630ce9464e750725fc368390af6
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jordan Petridis 3abe0803d6 Source: Remove reduntant save() call 
Source::clear_etags does a save already, so it's not needed to call
it twice.
 2018-08-17 09:57:49 +03:00
Jordan Petridis 489e8aa4b3 Source: Improve http redirections handling 
We should follow all redirects, and update the Source uri for
301, 302 and 308 codes.

Closes #85
 2018-08-17 07:09:12 +03:00
Jordan Petridis 49aff9f22e Source: Only save Etag headers upon succesful requests 
Additionally clear the Etags if the returned code is not 200 or 304.
Just to be extra safe. This is not as clean as it should, as this is
a temporary workaround until the API is reworked.

Related to #64
 2018-08-17 05:36:34 +03:00
Jordan Petridis 775d4accf7 Flatpak: switch to master branch of the runtime 2018-08-16 08:30:46 +03:00
Jordan Petridis 703a1baf8b CI: Move repo export right before the bundle generation 2018-08-16 08:30:42 +03:00
Jordan Petridis 51fdad2ae2 CI: Use variables instread of hardcoding things 2018-08-16 08:30:38 +03:00
Jordan Petridis 86545e5f99 CI: Add git commit sha in the bundle name 2018-08-16 08:30:34 +03:00
Jordan Petridis 5a0413b3e4 CI: Remove --libdir=/app/libdir from meson config 
This is not needed anymore I think.
 2018-08-16 08:30:29 +03:00
Jordan Petridis a0ff2b8ae4 CI: set CARGO_HOME before cargo test 
This is set in the scripts/cargo.sh during building, but since we
invoke cargo test manually we need to also set it here.
 2018-08-16 08:30:24 +03:00
Jordan Petridis cd937c4844 utils: Refactor refresh_feed 
Move channel creation inside the thread.
Drop the Result return type as its not needed anymore.
 2018-08-14 15:24:25 +03:00
Jordan Petridis cc1a5783fd App: Do not update the db if its empty 
If the source table is empty skipp the database refresh.
 2018-08-14 15:19:31 +03:00
Jordan Petridis 5631caad36 Gitlab: Fix the bug issue template 
Forgot to change this when it was copied from nautilus.
 2018-08-14 14:23:35 +03:00
Jordan Petridis d0144fb0d0 CI: Do not spin up review enviorment for tags 2018-08-14 14:11:16 +03:00
Jordan Petridis 5d1870c1cf CI: Lower flatpak bundle lifespan 2018-08-14 14:03:06 +03:00
Jordan Petridis fb87460bc7 CI: Clear unused stuff 
No point on keeping them around since libhandy was added as a dep.
No distro packages libhandy currently, so only the flatpak will be
buildable for the foreseeable future.
 2018-08-14 14:01:14 +03:00
Jordan Petridis cb122cbc61 ShowWidget: Change description wrap mode 2018-08-14 13:59:42 +03:00
Jordan Petridis efc4e299ac CI: Add env viariable for the tests 2018-08-14 13:58:09 +03:00
Jordan Petridis 848caa275b CI: re-enable the test-suite 2018-08-14 13:41:12 +03:00
Jordan Petridis 03754c56c6 Fix the test-suite 2018-08-14 13:40:37 +03:00
Jordan Petridis 471f6ff93b Source: Remove ignore_etags option 
This is never used anywhere else apart from the testsuite. Instead
of ignoring etags we should instead not save them if the feed does
not return 200 or 304. See #64.
 2018-08-14 13:40:33 +03:00
Jordan Petridis c53ad56a6d Remove TODOs and FIXMEs 
They are either no longer relevant or just forgotten
 2018-08-14 13:40:28 +03:00
Jordan Petridis ae7f65e938 InAppNotif: Switch the timer to milliseconds 
This allows for more responsive updates. The implementation still
sucks though. Ideally we would pass a receiver in the callback
and have an even lower timeout_add.
 2018-08-14 07:58:29 +03:00
Jordan Petridis b2d71a037c Headerbar: Remove the update indicator 2018-08-14 07:52:41 +03:00
Jordan Petridis 019ec8972f InAppNotif: Add a spinner 2018-08-14 07:41:58 +03:00
Jordan Petridis e25e411ebe App: Use the new updater notif 
Initial wiring of the new InAppNotif update indicator. This still
misses a spinner, and its overall teribly implemented!
 2018-08-14 07:28:10 +03:00
Jordan Petridis 911dcbac9f InAppNotif: Pass revealer to the callback 
Let the callback handle if/when the visibility of the notification
 2018-08-14 06:22:02 +03:00
Jordan Petridis 25195c972c InAppNotif: add a method to show/hide the close button 
This will enable us to create persistant notifications.
 2018-08-14 05:36:17 +03:00
Jordan Petridis 304c92f733 InAppNotification: Allow to set a custom timer 
This allows for a custom timer to be set before the
callback will be run. Currently all the callbacks only
run once and then retunr glib::Continue(false) but this
would allow for setting a low timer and have a callback
that would determine if it needs to be run again, Continue(true),
in a relative responsive way.
 2018-08-13 09:13:39 +03:00
Jordan Petridis 336b9a126e InAppNotif: Fix ref cycles 2018-08-13 09:13:10 +03:00
Jordan Petridis 01efbf5c79 InAppNotif: Refactor to infer the undo state 
If we use an Optional instead of passing empty closures, we
can infer if the Undo button needs to be shown.
 2018-08-13 08:31:52 +03:00
Jordan Petridis b8bb5e6d82 ShowMenu: Fix a reference cycle 2018-08-13 06:48:39 +03:00
Jordan Petridis cc4b3cce55 Player: Fix a refference cycle 2018-08-13 06:35:19 +03:00
Jordan Petridis 5699562133 App: Fix more refference cycles 2018-08-13 03:34:37 +00:00
Jordan Petridis d54e15cd15 EmptyView: Fix a typo 2018-08-13 04:05:28 +03:00
Jordan Petridis dbdf56d494 App: Do not placeholder strings as translatable 
Also add license metadata, and update the targeted gtk3 version
 2018-08-13 02:34:53 +03:00
Jordan Petridis b07cd5515a Refactor Empty states 2018-08-13 02:05:09 +03:00
Jordan Petridis acaa06749e ShowWidget: Keep the Frame from filling available the space 2018-08-12 02:41:22 +03:00
Jordan Petridis 5780df20ad Merge branch 'wip/piotrdrag/gschema-gettext' into 'master' 
gschema: Add gettext-domain

See merge request World/podcasts!56
 2018-08-11 09:24:05 +00:00
Jordan Petridis 7aa86bcec4 Merge branch 'wip/piotrdrag/update-potfiles-180810' into 'master' 
Update POTFILES.in

See merge request World/podcasts!54
 2018-08-10 23:20:38 +00:00
Jordan Petridis 093b8cb6df Merge branch 'wip/piotrdrag/desktop-comments' into 'master' 
desktop: Add translator comments

See merge request World/podcasts!55
 2018-08-10 20:56:30 +00:00
Jordan Petridis 662dc3fa85 HomeView: Properly align the frames 
d5ea0d5a17 broke alignment
between the listboxes and the frame labels.
 2018-08-10 22:49:54 +03:00
Jordan Petridis d5ea0d5a17 HoveView and ShowWiget: Add margins around the listboxes 2018-08-10 21:14:49 +03:00
Jordan Petridis 9e525727fd InAppNotif: allow the text to elipsize 
Also fixe deprications in the glae file, add license
 2018-08-10 20:49:59 +03:00
Jordan Petridis 95b6995649 Headerbar: Elipsisize update label 2018-08-10 15:54:12 +03:00
Jordan Petridis 745064c5ce AddPopOver: Remove deprication warning 2018-08-10 15:47:20 +03:00
Jordan Petridis 223a3b46bf Headerbar: Elipsisize show title 2018-08-10 15:46:28 +03:00
Jordan Petridis fee3e320ab ShowWidget: Move the listbox back to the glade file 2018-08-10 15:43:19 +03:00
Jordan Petridis e068cff37b ShowWidget: Increase the description char limit 2018-08-10 14:44:02 +03:00
Jordan Petridis 28f08ed196 HomeView: handle vadjustment with BaseView 
Instead of using lazy_static to save the adjustment,
pass it to the widget upon creation. If its the first instance
created, pass None instead.
 2018-08-10 14:43:58 +03:00
Jordan Petridis 056d971000 HomeView: make base view field publick 
There is no point to re-export BaseView's methods.
 2018-08-10 14:42:57 +03:00
Jordan Petridis aa5195e5a9 ShowsView: handle vadjustment with BaseView 
Instead of using lazy_static to save the adjustment,
pass it to the widget upon creation. If its the first instance
created, pass None instead.
 2018-08-10 14:42:52 +03:00
Jordan Petridis 85aaaf80ac ShowsView: make base view field publick 
There is no point to re-export BaseView's methods.
 2018-08-10 13:54:19 +03:00
Jordan Petridis 5d467a22d0 ShowWidget: make base view field publick 
There is no point to re-export BaseView's methods.
 2018-08-10 13:54:14 +03:00
Jordan Petridis bcc1cfb67b ShowWidget: handle vadjustment with BaseView 
Instead of using lazy_static to save the adjustment,
pass it to the widget upon creation. If previous it doesn't
exists pass None instead.
 2018-08-10 13:54:07 +03:00
Jordan Petridis 70a24fba69 BaseView: implement a set_adjustments method 
Ment to replace the individual set_vadjustment of widgets.
Also remove unused method from ShowWiget.
 2018-08-10 13:53:25 +03:00
Jordan Petridis c3121bef84 ShowsChild: Remove the need for a .ui file 
Its a simple enough widget that can be written by hand
and does not need a .ui builder file.
 2018-08-10 13:53:12 +03:00
Jordan Petridis 8c25be7d05 BaseView: Set scroll policy 2018-08-10 13:53:00 +03:00
Jordan Petridis 7463e9d42c ShowsView: Use BaseView abstraction 2018-08-10 13:52:56 +03:00
Jordan Petridis e4dd9f5bb3 HomeView: Use libhandy::Column for the main widget 2018-08-10 13:52:52 +03:00
Jordan Petridis 4e59d648ef HomeView: Use the new BaseView abstraction 2018-08-10 13:52:48 +03:00
Jordan Petridis 7538e76537 Gtk: Abstract a BaseView Widget 
Currently it just re-exports its children with getters,
but the idea is that it will also be able to handle
the saving the state of its height adjustment later.
 2018-08-10 13:52:44 +03:00
Jordan Petridis 20ddc54edc ShowWidget: Put the whole thing inside HdyColumn 2018-08-10 13:52:35 +03:00
Jordan Petridis ac75205933 ShowWidget: Initial prototype w/ libhandy::Column 2018-08-10 13:47:59 +03:00
Jordan Petridis 17b58b159a ShowWidget: Remove unsused menu from the glade file 2018-08-10 13:47:12 +03:00
Jordan Petridis 191cf445ef ShowWidget: Do not hardcode the episode listbox in the glade file 2018-08-10 13:47:07 +03:00
Jordan Petridis 65a0c08cb3 Flatpak: fix previous commit that broke it 
I broke both the manifest and the CI in 4da68ff89c
 2018-08-10 13:44:48 +03:00
Jordan Petridis 4da68ff89c Flatpak: switch to using the 3.28 runtime again 
Gtk was upgraded yesterday to 3.24. This causes a warning about
widgets being drawn without prior allocation. I am not sure yet if
the bug is in the bindings or if gtk's ABI broke.
 2018-08-10 12:11:08 +03:00
Jordan Petridis a7da4525fd Flatpak: Grant access to thee dri 
A warning suggested it, I assume it was coming from Gtk.
 2018-08-10 12:08:54 +03:00
Jordan Petridis 92dfbce45a Merge branch 'wip/piotrdrag/review-strings' into 'master' 
podcasts-gtk: Review ALL the strings!

See merge request World/podcasts!53
 2018-08-10 05:58:11 +00:00
Jordan Petridis a8a8c09b90 Merge branch 'wip/piotrdrag/appdata-fix' into 'master' 
appdata: Remove duplicate tag

See merge request World/podcasts!49
 2018-08-10 05:21:47 +00:00
Jordan Petridis 5a07600664 Merge branch 'wip/piotrdrag/unmark-placeholders' into 'master' 
episode_widget: Unmark placeholder strings from translation

See merge request World/podcasts!50
 2018-08-10 04:59:39 +00:00
Jordan Petridis 778975fbde Merge branch 'wip/piotrdrag/unmark-copyright' into 'master' 
aboutdialog: Unmark copyright string from translation

See merge request World/podcasts!51
 2018-08-10 04:36:54 +00:00
Jordan Petridis 3d87940da9 Merge branch 'wip/piotrdrag/translate-appname' into 'master' 
aboutdialog: Translate the app name

See merge request World/podcasts!52
 2018-08-10 04:04:04 +00:00
Jordan Petridis a01cf21f2c Flatpak: use master runtime of GNOME sdk 2018-08-09 10:25:02 +03:00
Jordan Petridis 10fc1d4a2a Gitlab: Add merge request template 2018-08-09 10:23:34 +03:00
Jordan Petridis 4fa973007d App: Make sure to quit on delete event. 
Since 9a76c6428a I've noticed
the applciation does not quit properly, and then it's unable
to be launched again till it's killed manually.

This patch is an attept to correct/workaroud that by calling
explcitly gio::ApplicationExt::quit().
 2018-08-06 01:01:21 +03:00
Jordan Petridis c27f5ec02e Merge branch 'readme_improvements' into 'master' 
Fix some typos in README.md

See merge request World/podcasts!47
 2018-08-05 08:57:26 +00:00
Jordan Petridis f6c7731377 Fix Rust 2018 edition warnings 2018-08-05 11:24:20 +03:00
Jordan Petridis bcd739da76 Merge branch 'i18n' into 'master' 
Translation support and initial spanish translation

See merge request World/podcasts!46
 2018-08-02 14:54:41 +00:00
Jordan Petridis f695ba4605 cargo fmt 2018-08-02 07:10:22 +03:00
Jordan Petridis 24983ba3af Readme.md: Improve wording and formatting 2018-08-02 02:44:29 +00:00
Jordan Petridis 0a2a3b3377 Remove unused permission. 2018-08-01 02:14:27 +03:00
Jordan Petridis d8d7193cbc README: Add flahub instructions. 2018-07-31 11:40:05 +03:00
Jordan Petridis 042c9eed9c Appdata: Remove 'lang=' metadata tag from the description. 
This seems to confuse the flathub store website.
 2018-07-31 11:22:15 +03:00
Jordan Petridis b0c94dd998 Appdata: Add OARS Rating 
This help with content age rating. Usefull for store
clients like gnome-software.

https://hughsie.github.io/oars/
 2018-07-31 10:58:04 +03:00
Jordan Petridis 4c8cc9e823 Version bump. 2018-07-31 00:31:44 +03:00
Jordan Petridis 132c9bbdff ShowModel: Remove dead unused methods. 2018-07-30 23:23:58 +03:00
Jordan Petridis cc0caff8d0 EpisodeModels: Remove unused methods. 2018-07-30 23:20:10 +03:00
Jordan Petridis 3496df24f8 App: Fix refference cycles in actions. 2018-07-28 19:52:37 +03:00
Jordan Petridis e4e35e4c57 App: Replace action macro with a generic fuction. 2018-07-28 19:52:27 +03:00
Jordan Petridis 838320785e Replace SendCell with fragile. 
SendCell is depricated now and its advised to use the Fragile
crate instead.

https://github.com/sdroege/send-cell/issues/5
 2018-07-28 19:46:01 +03:00
Jordan Petridis 91bea85519 Update dependancies. 2018-07-28 19:15:26 +03:00
Jordan Petridis 88ea081661 Version bump. 2018-07-28 00:12:08 +03:00
Jordan Petridis 39c0a0dba5 Fix cargo vendor config. 2018-07-28 00:08:48 +03:00
Jordan Petridis 9d64d3e30d AppStream: captions were too short. 2018-07-27 21:45:33 +03:00
Jordan Petridis 39ff238716 Version bump. 2018-07-27 20:21:28 +03:00
Jordan Petridis 7c96152f3f Gtk: Change the minimum requests of the views. 2018-07-27 19:46:18 +03:00
Jordan Petridis a2440c19e1 Appdata: Fix screenshots metadata. 2018-07-27 00:42:54 +03:00
Jordan Petridis 24dff5ce85 Update the release script. 2018-07-27 00:27:42 +03:00
Jordan Petridis 48a7c8140f Update screenshots. 2018-07-26 23:53:08 +03:00