Commit Graph
1389 Commits
Author SHA1 Message Date
Jordan Petridis 9f42e91088 Refactor content state with Application actions
Instead of each view/widget determening if its populated on its own,
make add Application Actions and apply the state globally.
2018-08-19 13:44:11 +03:00
Jordan Petridis 79ac3b9700 Update dependancies 2018-08-18 18:33:26 +03:00
Jordan Petridis 7a3178896b Remove criterion
Haven't been able to use it effectivly with futures. Maybe will
revisit it again at a later time. For now it just adds extra
build time.
2018-08-18 18:02:28 +03:00
Jordan Petridis ee95512321 Update .gitignore 2018-08-18 17:37:06 +03:00
Jordan Petridis 55519b1855 scripts/test.sh: avoid conlfict with vanila cargo
I am not sure why, but cargo does not like it if flatpak-builder
and gnome Builder try to use the same target/ directory, even
though the environment should be almost identical.

The only difference is that Builder uses flatpak build instead of
flatpak-builder as far as I can see.
2018-08-18 17:34:49 +03:00
Jordan Petridis 89b99614a0 Refactor the tests to use ? operator
As of ructc 1.27 #[test] can return errors. This improves a great
deal the ergonomics.
2018-08-18 17:02:31 +03:00
Jordan Petridis 7bbd9a1a4f Update the test script 2018-08-18 16:25:43 +03:00
Tobias Bernard 0dfb48593e App icon: orange -> red 2018-08-17 12:49:44 +02:00
Jordan Petridis 3abe0803d6 Source: Remove reduntant save() call
Source::clear_etags does a save already, so it's not needed to call
it twice.
2018-08-17 09:57:49 +03:00
Merge Bot 1e0a919dc7 Merge branch 'alatiera/source-redirects-85' into 'master'
Source: Improve http redirections handling

Closes #85

See merge request World/podcasts!62
2018-08-17 04:33:12 +00:00
Jordan Petridis 489e8aa4b3 Source: Improve http redirections handling
We should follow all redirects, and update the Source uri for
301, 302 and 308 codes.

Closes #85
2018-08-17 07:09:12 +03:00
Merge Bot 5058f2f8d8 Merge branch 'alatiera/source-etags-71' into 'master'
Source: Only save Etag headers upon succesful requests

Closes #64

See merge request World/podcasts!61
2018-08-17 02:56:04 +00:00
Jordan Petridis 49aff9f22e Source: Only save Etag headers upon succesful requests
Additionally clear the Etags if the returned code is not 200 or 304.
Just to be extra safe. This is not as clean as it should, as this is
a temporary workaround until the API is reworked.

Related to #64
2018-08-17 05:36:34 +03:00
Jordan Petridis 775d4accf7 Flatpak: switch to master branch of the runtime 2018-08-16 08:30:46 +03:00
Jordan Petridis 703a1baf8b CI: Move repo export right before the bundle generation 2018-08-16 08:30:42 +03:00
Jordan Petridis 51fdad2ae2 CI: Use variables instread of hardcoding things 2018-08-16 08:30:38 +03:00
Jordan Petridis 86545e5f99 CI: Add git commit sha in the bundle name 2018-08-16 08:30:34 +03:00
Jordan Petridis 5a0413b3e4 CI: Remove --libdir=/app/libdir from meson config
This is not needed anymore I think.
2018-08-16 08:30:29 +03:00
Jordan Petridis a0ff2b8ae4 CI: set CARGO_HOME before cargo test
This is set in the scripts/cargo.sh during building, but since we
invoke cargo test manually we need to also set it here.
2018-08-16 08:30:24 +03:00
Mario Blättermann 6b6c390cb8 Add German translation 2018-08-15 17:19:11 +00:00
Jordan Petridis cd937c4844 utils: Refactor refresh_feed
Move channel creation inside the thread.
Drop the Result return type as its not needed anymore.
2018-08-14 15:24:25 +03:00
Jordan Petridis cc1a5783fd App: Do not update the db if its empty
If the source table is empty skipp the database refresh.
2018-08-14 15:19:31 +03:00
Jordan Petridis 5631caad36 Gitlab: Fix the bug issue template
Forgot to change this when it was copied from nautilus.
2018-08-14 14:23:35 +03:00
Jordan Petridis d0144fb0d0 CI: Do not spin up review enviorment for tags 2018-08-14 14:11:16 +03:00
Jordan Petridis 5d1870c1cf CI: Lower flatpak bundle lifespan 2018-08-14 14:03:06 +03:00
Jordan Petridis fb87460bc7 CI: Clear unused stuff
No point on keeping them around since libhandy was added as a dep.
No distro packages libhandy currently, so only the flatpak will be
buildable for the foreseeable future.
2018-08-14 14:01:14 +03:00
Jordan Petridis cb122cbc61 ShowWidget: Change description wrap mode 2018-08-14 13:59:42 +03:00
Jordan Petridis efc4e299ac CI: Add env viariable for the tests 2018-08-14 13:58:09 +03:00
Jordan Petridis 848caa275b CI: re-enable the test-suite 2018-08-14 13:41:12 +03:00
Jordan Petridis 03754c56c6 Fix the test-suite 2018-08-14 13:40:37 +03:00
Jordan Petridis 471f6ff93b Source: Remove ignore_etags option
This is never used anywhere else apart from the testsuite. Instead
of ignoring etags we should instead not save them if the feed does
not return 200 or 304. See #64.
2018-08-14 13:40:33 +03:00
Jordan Petridis c53ad56a6d Remove TODOs and FIXMEs
They are either no longer relevant or just forgotten
2018-08-14 13:40:28 +03:00
Tobias Bernard 646439d86a Merge branch 'alatiera/move-update-notif' into 'master'
Move the update indication into an In-app Notification

Closes #72

See merge request World/podcasts!60
2018-08-14 10:11:28 +00:00
Jordan Petridis ae7f65e938 InAppNotif: Switch the timer to milliseconds
This allows for more responsive updates. The implementation still
sucks though. Ideally we would pass a receiver in the callback
and have an even lower timeout_add.
2018-08-14 07:58:29 +03:00
Jordan Petridis b2d71a037c Headerbar: Remove the update indicator 2018-08-14 07:52:41 +03:00
Jordan Petridis 019ec8972f InAppNotif: Add a spinner 2018-08-14 07:41:58 +03:00
Jordan Petridis e25e411ebe App: Use the new updater notif
Initial wiring of the new InAppNotif update indicator. This still
misses a spinner, and its overall teribly implemented!
2018-08-14 07:28:10 +03:00
Jordan Petridis 911dcbac9f InAppNotif: Pass revealer to the callback
Let the callback handle if/when the visibility of the notification
2018-08-14 06:22:02 +03:00
Jordan Petridis 25195c972c InAppNotif: add a method to show/hide the close button
This will enable us to create persistant notifications.
2018-08-14 05:36:17 +03:00
Jordan Petridis 304c92f733 InAppNotification: Allow to set a custom timer
This allows for a custom timer to be set before the
callback will be run. Currently all the callbacks only
run once and then retunr glib::Continue(false) but this
would allow for setting a low timer and have a callback
that would determine if it needs to be run again, Continue(true),
in a relative responsive way.
2018-08-13 09:13:39 +03:00
Jordan Petridis 336b9a126e InAppNotif: Fix ref cycles 2018-08-13 09:13:10 +03:00
Jordan Petridis 01efbf5c79 InAppNotif: Refactor to infer the undo state
If we use an Optional instead of passing empty closures, we
can infer if the Undo button needs to be shown.
2018-08-13 08:31:52 +03:00
Merge Bot, Bors Wannabe 866fa6a758 Merge branch 'fix-ref-cycles' into 'master'
Fix more refference cycles

See merge request World/podcasts!59
2018-08-13 04:28:49 +00:00
Jordan Petridis b8bb5e6d82 ShowMenu: Fix a reference cycle 2018-08-13 06:48:39 +03:00
Jordan Petridis cc4b3cce55 Player: Fix a refference cycle 2018-08-13 06:35:19 +03:00
Jordan Petridis 5699562133 App: Fix more refference cycles 2018-08-13 03:34:37 +00:00
Piotr Drąg dae064d2bb Update Polish translation 2018-08-13 01:45:08 +00:00
Jordan Petridis d54e15cd15 EmptyView: Fix a typo 2018-08-13 04:05:28 +03:00
Jordan Petridis dbdf56d494 App: Do not placeholder strings as translatable
Also add license metadata, and update the targeted gtk3 version
2018-08-13 02:34:53 +03:00
Jordan Petridis b07cd5515a Refactor Empty states 2018-08-13 02:05:09 +03:00